media: atomisp: Simplify v4l2_fh_open() error handling

v4l2_fh_open() can only fail with -ENOMEM and as a generic rule drivers
do not log their own errors for -ENOMEM since the kernel will already
have complained loudly about this before the -ENOMEM return.

Remove the unnecessary error logging from atomisp_open().

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c
index 61571f3fb0604a6911791066851e87c78c7e6894..fa37defa5eccf10883d1c3eedba5abfa2e4654e4 100644 (file)
--- a/drivers/staging/media/atomisp/pci/atomisp_fops.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c
@@ -708,12 +708,8 @@ static int atomisp_open(struct file *file)
        dev_dbg(isp->dev, "open device %s\n", vdev->name);
 
        ret = v4l2_fh_open(file);
-       if (ret) {
-               dev_err(isp->dev,
-                       "%s: v4l2_fh_open() returned error %d\n",
-                      __func__, ret);
+       if (ret)
                return ret;
-       }
 
        rt_mutex_lock(&isp->mutex);