mmc: sdhci-pci-gli: Improve GL9763E L1 entry delay to increase battery life
authorBen Chuang <ben.chuang@genesyslogic.com.tw>
Wed, 7 Apr 2021 09:38:16 +0000 (17:38 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 12 Apr 2021 07:09:05 +0000 (09:09 +0200)
For GL9763E, although there is the best performance at the maximum delay.
Change the value to 20us in order to have better power consumption.
This change may reduce the maximum performance by 10%.

Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
Link: https://lore.kernel.org/r/20210407093816.8863-1-benchuanggli@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-pci-gli.c

index fd0939355584adff896c6f31ac7488f00934e9e1..eb1ebb67e113687f3e734d7652c0ddef61b61360 100644 (file)
@@ -90,7 +90,7 @@
 
 #define PCIE_GLI_9763E_CFG2      0x8A4
 #define   GLI_9763E_CFG2_L1DLY     GENMASK(28, 19)
-#define   GLI_9763E_CFG2_L1DLY_MAX 0x3FF
+#define   GLI_9763E_CFG2_L1DLY_MID 0x50
 
 #define PCIE_GLI_9763E_MMC_CTRL  0x960
 #define   GLI_9763E_HS400_SLOW     BIT(3)
@@ -810,8 +810,8 @@ static void gli_set_gl9763e(struct sdhci_pci_slot *slot)
 
        pci_read_config_dword(pdev, PCIE_GLI_9763E_CFG2, &value);
        value &= ~GLI_9763E_CFG2_L1DLY;
-       /* set ASPM L1 entry delay to 260us */
-       value |= FIELD_PREP(GLI_9763E_CFG2_L1DLY, GLI_9763E_CFG2_L1DLY_MAX);
+       /* set ASPM L1 entry delay to 20us */
+       value |= FIELD_PREP(GLI_9763E_CFG2_L1DLY, GLI_9763E_CFG2_L1DLY_MID);
        pci_write_config_dword(pdev, PCIE_GLI_9763E_CFG2, value);
 
        pci_read_config_dword(pdev, PCIE_GLI_9763E_CLKRXDLY, &value);