ACPI: properties: Consistently return -ENOENT if there are no more references

__acpi_node_get_property_reference() is documented to return -ENOENT if
the caller requests a property reference at an index that does not exist,
not -EINVAL which it actually does.

Fix this by returning -ENOENT consistenly, independently of whether the
property value is a plain reference or a package.

Fixes: c343bc2ce2c6 ("ACPI: properties: Align return codes of __acpi_node_get_property_reference()")
Cc: 4.14+ <stable@vger.kernel.org> # 4.14+
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index d0986bda29640be63d27e1dafca7460483c2009d..3fceb4681ec9f871bf2a92da88c161bb409d7cc3 100644 (file)
--- a/drivers/acpi/property.c
+++ b/drivers/acpi/property.c
@@ -685,7 +685,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode,
         */
        if (obj->type == ACPI_TYPE_LOCAL_REFERENCE) {
                if (index)
-                       return -EINVAL;
+                       return -ENOENT;
 
                device = acpi_fetch_acpi_dev(obj->reference.handle);
                if (!device)