pwm: meson: remove not needed check in meson_pwm_calc
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 24 May 2023 19:49:56 +0000 (21:49 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Fri, 23 Jun 2023 13:37:36 +0000 (15:37 +0200)
period >= duty implies that cnt >= duty_cnt. We verified before
that cnt <= 0xffff, therefore we can omit the check here.

Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-meson.c

index 33107204a951d72ea7b54423c93bd9c27ed0bb1f..aad4a0ed3b5a642215b545d27bcc012257001c76 100644 (file)
@@ -204,12 +204,7 @@ static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm,
                channel->hi = 0;
                channel->lo = cnt;
        } else {
-               /* Then check is we can have the duty with the same pre_div */
                duty_cnt = div64_u64(fin_freq * duty, NSEC_PER_SEC * (pre_div + 1));
-               if (duty_cnt > 0xffff) {
-                       dev_err(meson->chip.dev, "unable to get duty cycle\n");
-                       return -EINVAL;
-               }
 
                dev_dbg(meson->chip.dev, "duty=%llu pre_div=%u duty_cnt=%u\n",
                        duty, pre_div, duty_cnt);