platform/x86/amd/pmf: Add missing __iomem attribute to policy_base
authorArmin Wolf <W_Armin@gmx.de>
Fri, 23 Feb 2024 16:38:59 +0000 (17:38 +0100)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 12 Mar 2024 10:47:42 +0000 (12:47 +0200)
The value of policy_base is the return value of a devm_ioremap call,
which returns a __iomem pointer instead of an regular pointer.
Add the missing __iomem attribute.

Compile-tested only.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Link: https://lore.kernel.org/r/20240223163901.13504-1-W_Armin@gmx.de
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/amd/pmf/pmf.h
drivers/platform/x86/amd/pmf/tee-if.c

index 16999c5b334fd44537404c56ab325aff00ede667..bcf777a5659aa50340d6834503b7a87f69577b33 100644 (file)
@@ -229,7 +229,7 @@ struct amd_pmf_dev {
        struct delayed_work pb_work;
        struct pmf_action_table *prev_data;
        u64 policy_addr;
-       void *policy_base;
+       void __iomem *policy_base;
        bool smart_pc_enabled;
 };
 
index f8c0177afb0dae60d4f67f2876ba98c6100d1ceb..16973bebf55fe5c53441b8b0fed9691391b402ae 100644 (file)
@@ -346,7 +346,7 @@ static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev)
        if (!dev->policy_base)
                return -ENOMEM;
 
-       memcpy(dev->policy_buf, dev->policy_base, dev->policy_sz);
+       memcpy_fromio(dev->policy_buf, dev->policy_base, dev->policy_sz);
 
        amd_pmf_hex_dump_pb(dev);
        if (pb_side_load)