bcachefs: Delete warning from promote_alloc()
authorKent Overstreet <kent.overstreet@linux.dev>
Sun, 4 Jun 2023 23:40:35 +0000 (19:40 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:10:03 +0000 (17:10 -0400)
It's possible to see a -BCH_ERR_ENOSPC_disk_reservation here, and that's
fine.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/io.c

index 199a8348355aa18d621b7dbbf9c9bf7e3c5760d6..25a9f657910c6ede0509af8e1f3b83cdfb67d5ea 100644 (file)
@@ -2057,10 +2057,11 @@ static struct promote_op *__promote_alloc(struct btree_trans *trans,
                                .write_flags    = BCH_WRITE_ALLOC_NOWAIT|BCH_WRITE_CACHED,
                        },
                        btree_id, k);
+       /*
+        * possible errors: -BCH_ERR_nocow_lock_blocked,
+        * -BCH_ERR_ENOSPC_disk_reservation:
+        */
        if (ret) {
-               WARN_ONCE(ret != -BCH_ERR_nocow_lock_blocked,
-                         "%s: saw unknown error %s\n", __func__, bch2_err_str(ret));
-
                ret = rhashtable_remove_fast(&c->promote_table, &op->hash,
                                        bch_promote_params);
                BUG_ON(ret);