drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level'
authorLee Jones <lee.jones@linaro.org>
Mon, 16 Nov 2020 17:40:31 +0000 (17:40 +0000)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 16 Nov 2020 20:56:35 +0000 (15:56 -0500)
Also removing the call to amdgpu_atombios_encoder_get_backlight_level_from_reg()
since, according to Alex Deucher, "We call it again below indirectly".

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/amd/amdgpu/atombios_encoders.c: In function ‘amdgpu_atombios_encoder_init_backlight’:
 drivers/gpu/drm/amd/amdgpu/atombios_encoders.c:174:5: warning: variable ‘backlight_level’ set but not used [-Wunused-but-set-variable]

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/atombios_encoders.c

index fa817ebff9804863882f123a6ef6d7fcf67b0c0f..6134ed964027924d4f3e0f0485f00614adde1be2 100644 (file)
@@ -171,7 +171,6 @@ void amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder *amdgpu_encode
        struct backlight_properties props;
        struct amdgpu_backlight_privdata *pdata;
        struct amdgpu_encoder_atom_dig *dig;
-       u8 backlight_level;
        char bl_name[16];
 
        /* Mac laptops with multiple GPUs use the gmux driver for backlight
@@ -207,8 +206,6 @@ void amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder *amdgpu_encode
 
        pdata->encoder = amdgpu_encoder;
 
-       backlight_level = amdgpu_atombios_encoder_get_backlight_level_from_reg(adev);
-
        dig = amdgpu_encoder->enc_priv;
        dig->bl_dev = bd;