ACPICA: utilities: fix sprintf()
authorJohn Levon <john.levon@joyent.com>
Fri, 27 Mar 2020 22:21:06 +0000 (15:21 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 30 Mar 2020 12:52:32 +0000 (14:52 +0200)
This contains changes for the following ACPICA commit ID's:
8f99a6ccd3b8e5c3d3d68c53fdbb054c2477eeb4
d30647af53abd334cbcf6362387464ea647bac9e
d3c5fb4cf5b2880d789c987eb847fc3de3774abc

On 32-bit, the provided sprintf() is non-functional: with a size of
ACPI_UINT32_MAX, String + Size will wrap, meaning End < Start, and
acpi_ut_bound_string_output() will never output anything as a result.

The symptom we saw of this was acpixtract failing to output anything.

Link: https://github.com/acpica/acpica/commit/8f99a6cc
Link: https://github.com/acpica/acpica/commit/d30647af
Link: https://github.com/acpica/acpica/commit/d3c5fb4c
Signed-off-by: MSathieu <18145111+MSathieu@users.noreply.github.com>
Signed-off-by: John Levon <john.levon@joyent.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/acpica/utprint.c

index a874dac7db5cc9ec46b97b422826d8506c15be62..681c11f4af4e89ed2d1f8e02b6c89244fa2646be 100644 (file)
@@ -332,7 +332,12 @@ int vsnprintf(char *string, acpi_size size, const char *format, va_list args)
        int i;
 
        pos = string;
-       end = string + size;
+
+       if (size != ACPI_UINT32_MAX) {
+               end = string + size;
+       } else {
+               end = ACPI_CAST_PTR(char, ACPI_UINT32_MAX);
+       }
 
        for (; *format; ++format) {
                if (*format != '%') {