qemu-img: Plug memory leak in convert command
authorMarkus Armbruster <armbru@redhat.com>
Wed, 28 May 2014 09:17:07 +0000 (11:17 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 30 May 2014 12:26:54 +0000 (14:26 +0200)
Introduced in commit 661a0f7.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
qemu-img.c

index 62ea27eae5133b0cee819e590f27860d5a5e2d74..d118da5c2fa74a01916f731898c72763d1929cbf 100644 (file)
@@ -1455,7 +1455,7 @@ static int img_convert(int argc, char **argv)
     ret = bdrv_parse_cache_flags(cache, &flags);
     if (ret < 0) {
         error_report("Invalid cache option: %s", cache);
-        return -1;
+        goto out;
     }
 
     out_bs = bdrv_new_open("target", out_filename, out_fmt, flags, true, quiet);