staging: rtl8192e: Remove ftrace-like logging in r8192E_firmware.c, ...

Remove "Unnecessary ftrace-like logging" as requested by checkpatch.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/370f47919a69f2f1717f50123c1617cabc78ceca.1663387785.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
index 4abec7b429939246c4c56bab23096dc09d41a914..956e8e2a728c381c247e77a4457b667ba29a025a 100644 (file)
--- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
@@ -115,10 +115,6 @@ bool rtl92e_config_rf(struct net_device *dev)
                                                (enum rf90_radio_path)eRFPath,
                                                RegOffSetToBeCheck,
                                                bMask12Bits);
-                       RT_TRACE(COMP_RF,
-                                "RF %d %d register final value: %x\n",
-                                eRFPath, RegOffSetToBeCheck,
-                                RF3_Final_Value);
                        RetryTimes--;
                }
 
@@ -142,8 +138,6 @@ bool rtl92e_config_rf(struct net_device *dev)
                        goto fail;
                }
        }
-
-       RT_TRACE(COMP_PHY, "PHY Initialization Success\n");
        return true;
 
 fail:

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
index cd8bbc358d016fe2e9eca3447fcdfe6396f98257..df6e1043fe19e058e5f509feada1e5edeff738ce 100644 (file)
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
@@ -21,8 +21,6 @@ bool rtl92e_send_cmd_pkt(struct net_device *dev, u32 type, const void *data,
 
        struct tx_fwinfo_8190pci *pTxFwInfo = NULL;
 
-       RT_TRACE(COMP_CMDPKT, "%s(),buffer_len is %d\n", __func__, len);
-
        do {
                if ((len - frag_offset) > CMDPACKET_FRAG_SIZE) {
                        frag_length = CMDPACKET_FRAG_SIZE;

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index 38110fa4f36de9a62b785fc41b3e5946604b0fcb..789d288d75037810926fbe06fe3f3fa7dcc8cb2a 100644 (file)
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
@@ -77,10 +77,6 @@ static bool _rtl92e_fw_check_ready(struct net_device *dev,
                rt_status = _rtl92e_wait_for_fw(dev, CPU_GEN_FIRM_RDY, 20);
                if (rt_status)
                        pfirmware->status = FW_STATUS_5_READY;
-               else
-                       RT_TRACE(COMP_FIRMWARE,
-                                "_rtl92e_is_fw_ready fail(%d)!\n",
-                                rt_status);
                break;
        default:
                rt_status = false;
@@ -149,9 +145,6 @@ bool rtl92e_init_fw(struct net_device *dev)
        } else if (pfirmware->status == FW_STATUS_5_READY) {
                rst_opt = OPT_FIRMWARE_RESET;
                starting_state = FW_INIT_STEP2_DATA;
-       } else {
-               RT_TRACE(COMP_FIRMWARE,
-                        "PlatformInitFirmware: undefined firmware state\n");
        }
 
        for (i = starting_state; i <= FW_INIT_STEP2_DATA; i++) {

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c
index 6b372b0dd6bcca39f1abe3428de75ab704b1ac97..8dba8606bda14aecd2a09defcee11881438b4f2b 100644 (file)
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c
@@ -46,10 +46,6 @@ void rtl92e_enable_hw_security_config(struct net_device *dev)
                ieee->hwsec_active = 0;
                SECR_value &= ~SCR_RxDecEnable;
        }
-
-       RT_TRACE(COMP_SEC, "%s:, hwsec:%d, pairwise_key:%d, SECR_value:%x\n",
-                __func__, ieee->hwsec_active, ieee->pairwise_key_type,
-                SECR_value);
        rtl92e_writeb(dev, SECR, SECR_value);
 }
 
@@ -60,10 +56,6 @@ void rtl92e_set_swcam(struct net_device *dev, u8 EntryNo, u8 KeyIndex,
        struct r8192_priv *priv = rtllib_priv(dev);
        struct rtllib_device *ieee = priv->rtllib;
 
-       RT_TRACE(COMP_DBG,
-                "===========>%s():EntryNo is %d,KeyIndex is %d,KeyType is %d,is_mesh is %d\n",
-                __func__, EntryNo, KeyIndex, KeyType, is_mesh);
-
        if (EntryNo >= TOTAL_CAM_ENTRY)
                return;
 
@@ -107,10 +99,6 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex,
                return;
        }
 
-       RT_TRACE(COMP_SEC,
-                "====>to %s, dev:%p, EntryNo:%d, KeyIndex:%d,KeyType:%d, MacAddr %pM\n",
-                __func__, dev, EntryNo, KeyIndex, KeyType, MacAddr);
-
        if (DefaultKey)
                usConfig |= BIT15 | (KeyType<<2);
        else
@@ -144,7 +132,6 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex,
                        }
                }
        }
-       RT_TRACE(COMP_SEC, "=========>after set key, usconfig:%x\n", usConfig);
 }
 
 void rtl92e_cam_restore(struct net_device *dev)
@@ -163,9 +150,6 @@ void rtl92e_cam_restore(struct net_device *dev)
                0xff, 0xff, 0xff, 0xff, 0xff, 0xff
        };
 
-       RT_TRACE(COMP_SEC, "%s:\n", __func__);
-
-
        if ((priv->rtllib->pairwise_key_type == KEY_TYPE_WEP40) ||
            (priv->rtllib->pairwise_key_type == KEY_TYPE_WEP104)) {
 

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
index 1d992d5c4e17f69cf33a090aa1668828ea2cb0bb..886bf4ba2adff3c43a7e1e5c65edca85974a6f32 100644 (file)
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
@@ -20,8 +20,6 @@ static void _rtl92e_parse_pci_configuration(struct pci_dev *pdev,
 
        pcie_capability_read_word(priv->pdev, PCI_EXP_LNKCTL, &LinkCtrlReg);
 
-       RT_TRACE(COMP_INIT, "Link Control Register =%x\n", LinkCtrlReg);
-
        pci_read_config_byte(pdev, 0x98, &tmp);
        tmp |= BIT4;
        pci_write_config_byte(pdev, 0x98, tmp);

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_pm.c
index 5575186caebddd1d166765762c62914bce048179..ced00de8911401588208ae94988eb07520affe8c 100644 (file)
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_pm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_pm.c
@@ -86,7 +86,6 @@ int rtl92e_resume(struct device *dev_d)
                rtl92e_set_rf_state(dev, eRfOn, RF_CHANGE_BY_INIT);
 
 out:
-       RT_TRACE(COMP_POWER, "<================r8192E resume call.\n");
        return 0;
 }
 

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
index ab0bd12ddfda3d134cc5dea4f0441f9b8ef377a0..bfb963768fc39eff3017b65bc3714c82b51f9533 100644 (file)
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
@@ -149,8 +149,6 @@ static int _rtl92e_wx_force_reset(struct net_device *dev,
 
        mutex_lock(&priv->wx_mutex);
 
-       RT_TRACE(COMP_DBG, "%s(): force reset ! extra is %d\n",
-                __func__, *extra);
        priv->force_reset = *extra;
        mutex_unlock(&priv->wx_mutex);
        return 0;
@@ -167,8 +165,6 @@ static int _rtl92e_wx_adapter_power_status(struct net_device *dev,
 
        mutex_lock(&priv->wx_mutex);
 
-       RT_TRACE(COMP_POWER, "%s(): %s\n", __func__, (*extra == 6) ?
-                "DC power" : "AC power");
        if (*extra || priv->force_lps) {
                priv->ps_force = false;
                pPSC->bLeisurePs = true;
@@ -427,9 +423,6 @@ static int _rtl92e_wx_set_scan(struct net_device *dev,
                                        mutex_unlock(&priv->wx_mutex);
                                        return -1;
                                }
-                               RT_TRACE(COMP_PS,
-                                        "=========>%s(): rtl92e_ips_leave\n",
-                                        __func__);
                                mutex_lock(&priv->rtllib->ips_mutex);
                                rtl92e_ips_leave(dev);
                                mutex_unlock(&priv->rtllib->ips_mutex);
@@ -681,7 +674,6 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
        mutex_unlock(&priv->rtllib->ips_mutex);
        mutex_lock(&priv->wx_mutex);
 
-       RT_TRACE(COMP_SEC, "Setting SW wep key");
        ret = rtllib_wx_set_encode(priv->rtllib, info, wrqu, key);
        mutex_unlock(&priv->wx_mutex);