nexthop: Remove in-kernel route notifications when nexthop changes

Remove in-kernel route notifications when the configuration of their
nexthop changes.

These notifications are unnecessary because the route still uses the
same nexthop ID. A separate notification for the nexthop change itself
is now sent in the nexthop notification chain.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
index ffc5332f139062525e92e1f03b197524842a02f1..28117c05dc353eaccd3e0e18cae02e807427e3b6 100644 (file)
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -2100,15 +2100,6 @@ static void __fib_info_notify_update(struct net *net, struct fib_table *tb,
                        rtmsg_fib(RTM_NEWROUTE, htonl(n->key), fa,
                                  KEYLENGTH - fa->fa_slen, tb->tb_id,
                                  info, NLM_F_REPLACE);
-
-                       /* call_fib_entry_notifiers will be removed when
-                        * in-kernel notifier is implemented and supported
-                        * for nexthop objects
-                        */
-                       call_fib_entry_notifiers(net, FIB_EVENT_ENTRY_REPLACE,
-                                                n->key,
-                                                KEYLENGTH - fa->fa_slen, fa,
-                                                NULL);
                }
        }
 }

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 7e0ce7af823460356783e45b3b80abe3304b8c50..f91a689edafd21d89880a4a32c16c4f98a3df018 100644 (file)
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -6039,11 +6039,6 @@ void fib6_rt_update(struct net *net, struct fib6_info *rt,
        struct sk_buff *skb;
        int err = -ENOBUFS;
 
-       /* call_fib6_entry_notifiers will be removed when in-kernel notifier
-        * is implemented and supported for nexthop objects
-        */
-       call_fib6_entry_notifiers(net, FIB_EVENT_ENTRY_REPLACE, rt, NULL);
-
        skb = nlmsg_new(rt6_nlmsg_size(rt), gfp_any());
        if (!skb)
                goto errout;