PM / devfreq: rockchip-dfi: Embed desc into private data struct
authorSascha Hauer <s.hauer@pengutronix.de>
Tue, 4 Jul 2023 09:32:18 +0000 (11:32 +0200)
committerChanwoo Choi <cw00.choi@samsung.com>
Sun, 8 Oct 2023 22:28:50 +0000 (07:28 +0900)
No need for an extra allocation, just embed the struct
devfreq_event_desc into the private data struct.

Link: https://lore.kernel.org/lkml/20230704093242.583575-3-s.hauer@pengutronix.de/
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/devfreq/event/rockchip-dfi.c

index 74893c06aa087f0be976aff02b5cdeff08a5f10d..467f9f42d38f7b815792829356ed449dd418fe66 100644 (file)
@@ -49,7 +49,7 @@ struct dmc_usage {
  */
 struct rockchip_dfi {
        struct devfreq_event_dev *edev;
-       struct devfreq_event_desc *desc;
+       struct devfreq_event_desc desc;
        struct dmc_usage ch_usage[RK3399_DMC_NUM_CH];
        struct device *dev;
        void __iomem *regs;
@@ -204,14 +204,10 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
 
        data->dev = dev;
 
-       desc = devm_kzalloc(dev, sizeof(*desc), GFP_KERNEL);
-       if (!desc)
-               return -ENOMEM;
-
+       desc = &data->desc;
        desc->ops = &rockchip_dfi_ops;
        desc->driver_data = data;
        desc->name = np->name;
-       data->desc = desc;
 
        data->edev = devm_devfreq_event_add_edev(&pdev->dev, desc);
        if (IS_ERR(data->edev)) {