macintosh/ams: Fix unused variable warning
authorMichael Ellerman <mpe@ellerman.id.au>
Tue, 7 May 2024 14:01:50 +0000 (00:01 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 7 May 2024 14:05:30 +0000 (00:05 +1000)
If both CONFIG_SENSORS_AMS_PMU and CONFIG_SENSORS_AMS_I2C are unset,
there is an unused variable warning in the ams driver:

  drivers/macintosh/ams/ams-core.c: In function 'ams_init':
  drivers/macintosh/ams/ams-core.c:181:29: warning: unused variable 'np'
    181 |         struct device_node *np;

The driver needs at least one of the configs enabled in order to
actually function. So fix the compiler warning by ensuring at least one
of the configs is enabled.

Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240507140150.54630-1-mpe@ellerman.id.au
drivers/macintosh/Kconfig

index a0e717a986dcb3dff5a6a15a1cc014a2e3fd432b..fb38f684444f2c07b832b6e5251aadfeb2b398ef 100644 (file)
@@ -262,7 +262,7 @@ config SENSORS_AMS
          will be called ams.
 
 config SENSORS_AMS_PMU
-       bool "PMU variant"
+       bool "PMU variant" if SENSORS_AMS_I2C
        depends on SENSORS_AMS && ADB_PMU
        default y
        help