leds: lm3697: Annotate struct lm3697 with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 15 Sep 2023 20:10:10 +0000 (13:10 -0700)
committerLee Jones <lee@kernel.org>
Wed, 1 Nov 2023 11:28:31 +0000 (11:28 +0000)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct lm3697.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230915201010.never.399-kees@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-lm3697.c

index cfb8ac220db6da36971d6c4ac9e25427d67b3178..380d17a58fe934cdc5ba5f2cafdc73ef8a0fd6fc 100644 (file)
@@ -89,7 +89,7 @@ struct lm3697 {
        int bank_cfg;
        int num_banks;
 
-       struct lm3697_led leds[];
+       struct lm3697_led leds[] __counted_by(num_banks);
 };
 
 static const struct reg_default lm3697_reg_defs[] = {