arm64: dts: exynos850: add specific compatibles to several blocks
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 8 Nov 2023 10:43:42 +0000 (11:43 +0100)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 15 Nov 2023 11:50:40 +0000 (12:50 +0100)
Exynos850 reuses several devices from older designs, thus historically
we kept the old (block's) compatible only.  This works fine and there is
no bug here, however guidelines expressed in
Documentation/devicetree/bindings/writing-bindings.rst state that:
1. Compatibles should be specific.
2. We should add new compatibles in case of bugs or features.

Add compatibles specific to Exynos850 in front of all old-SoC-like
compatibles.  This will also help reviews of new code using existing
DTS as template.  No functional impact on Linux drivers behavior.

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Link: https://lore.kernel.org/r/20231108104343.24192-17-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
arch/arm64/boot/dts/exynos/exynos850.dtsi

index 53104e65b9c67024e23468713d3a8da8341d7bc5..df5ea43ebcadb12f4c090bb238be84b6ca279be0 100644 (file)
                };
 
                rtc: rtc@11a30000 {
-                       compatible = "samsung,s3c6410-rtc";
+                       compatible = "samsung,exynos850-rtc", "samsung,s3c6410-rtc";
                        reg = <0x11a30000 0x100>;
                        interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
                                     <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
                };
 
                mmc_0: mmc@12100000 {
-                       compatible = "samsung,exynos7-dw-mshc-smu";
+                       compatible = "samsung,exynos850-dw-mshc-smu",
+                                    "samsung,exynos7-dw-mshc-smu";
                        reg = <0x12100000 0x2000>;
                        interrupts = <GIC_SPI 452 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                i2c_0: i2c@13830000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
                        reg = <0x13830000 0x100>;
                        interrupts = <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                i2c_1: i2c@13840000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
                        reg = <0x13840000 0x100>;
                        interrupts = <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                i2c_2: i2c@13850000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
                        reg = <0x13850000 0x100>;
                        interrupts = <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                i2c_3: i2c@13860000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
                        reg = <0x13860000 0x100>;
                        interrupts = <GIC_SPI 199 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                i2c_4: i2c@13870000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
                        reg = <0x13870000 0x100>;
                        interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
 
                /* I2C_5 (also called CAM_PMIC_I2C in TRM) */
                i2c_5: i2c@13880000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
                        reg = <0x13880000 0x100>;
                        interrupts = <GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
 
                /* I2C_6 (also called MOTOR_I2C in TRM) */
                i2c_6: i2c@13890000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
                        reg = <0x13890000 0x100>;
                        interrupts = <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                        status = "disabled";
 
                        hsi2c_0: i2c@138a0000 {
-                               compatible = "samsung,exynosautov9-hsi2c";
+                               compatible = "samsung,exynos850-hsi2c",
+                                            "samsung,exynosautov9-hsi2c";
                                reg = <0x138a0000 0xc0>;
                                interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
                                #address-cells = <1>;
                        status = "disabled";
 
                        hsi2c_1: i2c@138b0000 {
-                               compatible = "samsung,exynosautov9-hsi2c";
+                               compatible = "samsung,exynos850-hsi2c",
+                                            "samsung,exynosautov9-hsi2c";
                                reg = <0x138b0000 0xc0>;
                                interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>;
                                #address-cells = <1>;
                        status = "disabled";
 
                        hsi2c_2: i2c@138c0000 {
-                               compatible = "samsung,exynosautov9-hsi2c";
+                               compatible = "samsung,exynos850-hsi2c",
+                                            "samsung,exynosautov9-hsi2c";
                                reg = <0x138c0000 0xc0>;
                                interrupts = <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>;
                                #address-cells = <1>;
                        status = "disabled";
 
                        hsi2c_3: i2c@11d00000 {
-                               compatible = "samsung,exynosautov9-hsi2c";
+                               compatible = "samsung,exynos850-hsi2c",
+                                            "samsung,exynosautov9-hsi2c";
                                reg = <0x11d00000 0xc0>;
                                interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
                                #address-cells = <1>;
                        status = "disabled";
 
                        hsi2c_4: i2c@11d20000 {
-                               compatible = "samsung,exynosautov9-hsi2c";
+                               compatible = "samsung,exynos850-hsi2c",
+                                            "samsung,exynosautov9-hsi2c";
                                reg = <0x11d20000 0xc0>;
                                interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
                                #address-cells = <1>;