tty: serial: owl: Fix missing clk_disable_unprepare() in owl_uart_probe
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 7 Mar 2022 10:51:35 +0000 (10:51 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Apr 2022 09:08:12 +0000 (11:08 +0200)
Fix the missing clk_disable_unprepare() before return
from owl_uart_probe() in the error handling case.

Fixes: abf42d2f333b ("tty: serial: owl: add "much needed" clk_prepare_enable()")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220307105135.11698-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/owl-uart.c

index 5ff7c89aeb065730f0afa481291d66a2076481c7..44d20e5a7dd358752de0bdb846f50453123b91d8 100644 (file)
@@ -731,6 +731,7 @@ static int owl_uart_probe(struct platform_device *pdev)
        owl_port->port.uartclk = clk_get_rate(owl_port->clk);
        if (owl_port->port.uartclk == 0) {
                dev_err(&pdev->dev, "clock rate is zero\n");
+               clk_disable_unprepare(owl_port->clk);
                return -EINVAL;
        }
        owl_port->port.flags = UPF_BOOT_AUTOCONF | UPF_IOREMAP | UPF_LOW_LATENCY;