clk: ti: clkctrl: check return value of kasprintf()
authorClaudiu Beznea <claudiu.beznea@microchip.com>
Tue, 30 May 2023 09:39:12 +0000 (12:39 +0300)
committerStephen Boyd <sboyd@kernel.org>
Sat, 17 Jun 2023 04:52:50 +0000 (21:52 -0700)
kasprintf() returns a pointer to dynamically allocated memory.
Pointer could be NULL in case allocation fails. Check pointer validity.
Identified with coccinelle (kmerr.cocci script).

Fixes: 852049594b9a ("clk: ti: clkctrl: convert subclocks to use proper names also")
Fixes: 6c3090520554 ("clk: ti: clkctrl: Fix hidden dependency to node name")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Link: https://lore.kernel.org/r/20230530093913.1656095-8-claudiu.beznea@microchip.com
Reviewed-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/ti/clkctrl.c

index b6fce916967cea8c9e5dd000004983830648ec82..8c40f10280b74e0ee7a5e466b04ca5b51af21d6a 100644 (file)
@@ -258,6 +258,9 @@ static const char * __init clkctrl_get_clock_name(struct device_node *np,
        if (clkctrl_name && !legacy_naming) {
                clock_name = kasprintf(GFP_KERNEL, "%s-clkctrl:%04x:%d",
                                       clkctrl_name, offset, index);
+               if (!clock_name)
+                       return NULL;
+
                strreplace(clock_name, '_', '-');
 
                return clock_name;
@@ -586,6 +589,10 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node)
        if (clkctrl_name) {
                provider->clkdm_name = kasprintf(GFP_KERNEL,
                                                 "%s_clkdm", clkctrl_name);
+               if (!provider->clkdm_name) {
+                       kfree(provider);
+                       return;
+               }
                goto clkdm_found;
        }