ipmi_si: Use proper ACPI macros to check error code for failures

Instead of direct comparison, use proper ACPI macros to check error code
for failures.

While at it, drop unneeded 'else' keyword.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Message-Id: <20210402174334.13466-5-andriy.shevchenko@linux.intel.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>

diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c
index 5f641d316ecb6ae16826cb39ba9f22c266eaf958..b87bd9933724a38bc5f077a755b2622e6143c21a 100644 (file)
--- a/drivers/char/ipmi/ipmi_si_platform.c
+++ b/drivers/char/ipmi/ipmi_si_platform.c
@@ -85,18 +85,18 @@ static int acpi_gpe_irq_setup(struct si_sm_io *io)
                                          ACPI_GPE_LEVEL_TRIGGERED,
                                          &ipmi_acpi_gpe,
                                          io);
-       if (status != AE_OK) {
+       if (ACPI_FAILURE(status)) {
                dev_warn(io->dev,
                         "Unable to claim ACPI GPE %d, running polled\n",
                         io->irq);
                io->irq = 0;
                return -EINVAL;
-       } else {
-               io->irq_cleanup = acpi_gpe_irq_cleanup;
-               ipmi_irq_finish_setup(io);
-               dev_info(io->dev, "Using ACPI GPE %d\n", io->irq);
-               return 0;
        }
+
+       io->irq_cleanup = acpi_gpe_irq_cleanup;
+       ipmi_irq_finish_setup(io);
+       dev_info(io->dev, "Using ACPI GPE %d\n", io->irq);
+       return 0;
 }
 #endif