of: unittest: fix an error test in of_unittest_overlay_8()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 7 Mar 2018 06:18:08 +0000 (09:18 +0300)
committerRob Herring <robh@kernel.org>
Thu, 8 Mar 2018 02:12:05 +0000 (20:12 -0600)
We changed this from of_overlay_apply() to overlay_data_apply().  The
overlay_data_apply() function returns 1 on success and 0 on error so
the check for less than zero needs to be updated.

Fixes: 39a751a4cb7e ("of: change overlay apply input data from unflattened to FDT")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/unittest.c

index 62c8a8b8af2d54b543c0d5f142035e6f9b0280af..20ffbedac524b789d3955191d298b0594e536f4d 100644 (file)
@@ -1696,8 +1696,7 @@ static void __init of_unittest_overlay_8(void)
 
                overlay_name = overlay_name_from_nr(overlay_nr + i);
 
-               ret = overlay_data_apply(overlay_name, &ovcs_id);
-               if (ret < 0)  {
+               if (!overlay_data_apply(overlay_name, &ovcs_id)) {
                        unittest(0, "could not apply overlay \"%s\"\n",
                                        overlay_name);
                        return;