thunderbolt: Do not call CLx functions from TMU code
authorMika Westerberg <mika.westerberg@linux.intel.com>
Mon, 10 Oct 2022 15:52:24 +0000 (18:52 +0300)
committerMika Westerberg <mika.westerberg@linux.intel.com>
Fri, 9 Jun 2023 09:07:23 +0000 (12:07 +0300)
There is really no need to call any of the CLx functions in the TMU code
so remove all these checks. This makes the TMU enable/disable flows
easier to follow as well.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/thunderbolt/tmu.c

index 6988704c845cf4a77aa8cf8b55448820b8106871..7d06bacf24ffa4b89e544a4a5557317ac5d8bb50 100644 (file)
@@ -383,14 +383,6 @@ out:
  */
 int tb_switch_tmu_disable(struct tb_switch *sw)
 {
-       /*
-        * No need to disable TMU on devices that don't support CLx since
-        * on these devices e.g. Alpine Ridge and earlier, the TMU mode
-        * HiFi bi-directional is enabled by default and we don't change it.
-        */
-       if (!tb_switch_clx_is_supported(sw))
-               return 0;
-
        /* Already disabled? */
        if (sw->tmu.rate == TB_SWITCH_TMU_RATE_OFF)
                return 0;
@@ -648,25 +640,10 @@ int tb_switch_tmu_enable(struct tb_switch *sw)
        bool unidirectional = sw->tmu.unidirectional_request;
        int ret;
 
-       /*
-        * No need to enable TMU on devices that don't support CLx since on
-        * these devices e.g. Alpine Ridge and earlier, the TMU mode HiFi
-        * bi-directional is enabled by default.
-        */
-       if (!tb_switch_clx_is_supported(sw))
-               return 0;
-
        if (tb_switch_tmu_is_enabled(sw))
                return 0;
 
        if (tb_switch_is_titan_ridge(sw) && unidirectional) {
-               /*
-                * Titan Ridge supports CL0s and CL1 only. CL0s and CL1 are
-                * enabled and supported together.
-                */
-               if (!tb_switch_clx_is_enabled(sw, TB_CL1))
-                       return -EOPNOTSUPP;
-
                ret = tb_switch_tmu_disable_objections(sw);
                if (ret)
                        return ret;