soc: xilinx: Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:47:24 +0000 (08:47 -0600)
committerMichal Simek <michal.simek@amd.com>
Fri, 12 May 2023 11:06:14 +0000 (13:06 +0200)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230310144725.1545315-1-robh@kernel.org
Signed-off-by: Michal Simek <michal.simek@amd.com>
drivers/soc/xilinx/zynqmp_power.c

index 78a8a7545d1eda1dc3949037c5be957b38edee72..641dcc95891164730a8c157149cf3348df4ad8fa 100644 (file)
@@ -218,7 +218,7 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
        } else if (ret != -EACCES && ret != -ENODEV) {
                dev_err(&pdev->dev, "Failed to Register with Xilinx Event manager %d\n", ret);
                return ret;
-       } else if (of_find_property(pdev->dev.of_node, "mboxes", NULL)) {
+       } else if (of_property_present(pdev->dev.of_node, "mboxes")) {
                zynqmp_pm_init_suspend_work =
                        devm_kzalloc(&pdev->dev,
                                     sizeof(struct zynqmp_pm_work_struct),
@@ -240,7 +240,7 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
                        dev_err(&pdev->dev, "Failed to request rx channel\n");
                        return PTR_ERR(rx_chan);
                }
-       } else if (of_find_property(pdev->dev.of_node, "interrupts", NULL)) {
+       } else if (of_property_present(pdev->dev.of_node, "interrupts")) {
                irq = platform_get_irq(pdev, 0);
                if (irq <= 0)
                        return -ENXIO;