scsi: ips: Change the return type of ips_release() into 'void'
authorBart Van Assche <bvanassche@acm.org>
Fri, 18 Feb 2022 19:50:30 +0000 (11:50 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 23 Feb 2022 02:11:02 +0000 (21:11 -0500)
ips_release() has one caller and that caller ignores the value returned by
ips_release(). Hence change the return type of that function into 'void'.

Link: https://lore.kernel.org/r/20220218195117.25689-3-bvanassche@acm.org
Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: John Garry <john.garry@huawei.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ips.c

index 0db35e97ce8f5a40cc09d680b61fa41656f77bd7..59664e92ec8a1372ba624ee73ac22a32f5c6aeea 100644 (file)
@@ -638,8 +638,7 @@ ips_setup_funclist(ips_ha_t * ha)
 /*   Remove a driver                                                        */
 /*                                                                          */
 /****************************************************************************/
-static int
-ips_release(struct Scsi_Host *sh)
+static void ips_release(struct Scsi_Host *sh)
 {
        ips_scb_t *scb;
        ips_ha_t *ha;
@@ -660,7 +659,7 @@ ips_release(struct Scsi_Host *sh)
        ha = IPS_HA(sh);
 
        if (!ha)
-               return (FALSE);
+               return;
 
        /* flush the cache on the controller */
        scb = &ha->scbs[ha->max_cmds - 1];
@@ -698,8 +697,6 @@ ips_release(struct Scsi_Host *sh)
        scsi_host_put(sh);
 
        ips_released_controllers++;
-
-       return (FALSE);
 }
 
 /****************************************************************************/