projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5131797
)
rtc: r7301: Replace spin_lock_irqsave with spin_lock in hard IRQ
author
Xiaofei Tan
<tanxiaofei@huawei.com>
Wed, 3 Feb 2021 12:39:38 +0000
(20:39 +0800)
committer
Alexandre Belloni
<alexandre.belloni@bootlin.com>
Fri, 5 Feb 2021 23:50:47 +0000
(
00:50
+0100)
It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.
Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link:
https://lore.kernel.org/r/1612355981-6764-4-git-send-email-tanxiaofei@huawei.com
drivers/rtc/rtc-r7301.c
patch
|
blob
|
history
diff --git
a/drivers/rtc/rtc-r7301.c
b/drivers/rtc/rtc-r7301.c
index aaf1b95e3990916a7d7f77bbf2657e9c7d72df87..5dbaeb7af648b7db5ef0470d0a5a7874653e35c9 100644
(file)
--- a/
drivers/rtc/rtc-r7301.c
+++ b/
drivers/rtc/rtc-r7301.c
@@
-320,11
+320,10
@@
static irqreturn_t rtc7301_irq_handler(int irq, void *dev_id)
{
struct rtc_device *rtc = dev_id;
struct rtc7301_priv *priv = dev_get_drvdata(rtc->dev.parent);
- unsigned long flags;
irqreturn_t ret = IRQ_NONE;
u8 alrm_ctrl;
- spin_lock
_irqsave(&priv->lock, flags
);
+ spin_lock
(&priv->lock
);
rtc7301_select_bank(priv, 1);
@@
-335,7
+334,7
@@
static irqreturn_t rtc7301_irq_handler(int irq, void *dev_id)
rtc_update_irq(rtc, 1, RTC_IRQF | RTC_AF);
}
- spin_unlock
_irqrestore(&priv->lock, flags
);
+ spin_unlock
(&priv->lock
);
return ret;
}