media: pci: cx18: if cx == NULL, then don't use it.

If the cx NULL pointer check is true, then it reports
an error with CX18_ERR, but that uses cx. Replace it with
pr_err.

Reported by smatch:

drivers/media/pci/cx18/cx18-mailbox.c:834 cx18_vapi() error: we previously assumed 'cx' could be null (see line 833)

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/drivers/media/pci/cx18/cx18-mailbox.c b/drivers/media/pci/cx18/cx18-mailbox.c
index 3b283f3c672680ee947bb48222527b6d76457048..a6457c23d18c9e15b1e6793314a9c43e4df8a372 100644 (file)
--- a/drivers/media/pci/cx18/cx18-mailbox.c
+++ b/drivers/media/pci/cx18/cx18-mailbox.c
@@ -831,7 +831,7 @@ int cx18_vapi(struct cx18 *cx, u32 cmd, int args, ...)
        int i;
 
        if (cx == NULL) {
-               CX18_ERR("cx == NULL (cmd=%x)\n", cmd);
+               pr_err("cx == NULL (cmd=%x)\n", cmd);
                return 0;
        }
        if (args > MAX_MB_ARGUMENTS) {