scsi: lpfc: Wait for successful restart of SLI3 adapter during host sg_reset
authorJames Smart <jsmart2021@gmail.com>
Wed, 20 Oct 2021 21:14:11 +0000 (14:14 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 18:16:54 +0000 (19:16 +0100)
[ Upstream commit d305c253af693e69a36cedec880aca6d0c6d789d ]

A prior patch introduced HBA_NEEDS_CFG_PORT flag logic, but in
lpfc_sli_brdrestart_s3() code path, right after HBA_NEEDS_CFG_PORT is set,
the phba->hba_flag is cleared in lpfc_sli_brdreset().

Fix by calling lpfc_sli_chipset_init() to wait for successful restart of
the HBA in lpfc_host_reset_handler() after lpfc_sli_brdrestart().

lpfc_sli_chipset_init() sets the HBA_NEEDS_CFG_PORT flag so that the
lpfc_sli_hba_setup() routine from lpfc_online() will execute
lpfc_sli_config_port() initialization step when the brdrestart is
successful.

Link: https://lore.kernel.org/r/20211020211417.88754-3-jsmart2021@gmail.com
Fixes: d2f2547efd39 ("scsi: lpfc: Fix auto sli_mode and its effect on CONFIG_PORT for SLI3")
Co-developed-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/lpfc/lpfc_scsi.c

index befdf864c43bdc8f4a7c4310abd6750c08661f14..364c8a9b99095b0d4b4f2b01b858162c78a6c2ee 100644 (file)
@@ -6628,6 +6628,13 @@ lpfc_host_reset_handler(struct scsi_cmnd *cmnd)
        if (rc)
                goto error;
 
+       /* Wait for successful restart of adapter */
+       if (phba->sli_rev < LPFC_SLI_REV4) {
+               rc = lpfc_sli_chipset_init(phba);
+               if (rc)
+                       goto error;
+       }
+
        rc = lpfc_online(phba);
        if (rc)
                goto error;