iio:light:pa12203001: Improve error reporting for problems during .remove()

Returning an error value in an i2c remove callback results in a generic
error message being emitted by the i2c core, but otherwise it doesn't
make a difference. The device goes away anyhow and the devm cleanups are
called.

So instead of triggering the generic i2c error message, emit a more
helpful message if a problem occurs and return 0 to suppress the generic
message.

This patch is a preparation for making i2c remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220515155929.338656-6-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/light/pa12203001.c b/drivers/iio/light/pa12203001.c
index 528fa5dd2b1356aeb78e33dfd21ad533a73575aa..772874e707aec759266d95346158119749d44e53 100644 (file)
--- a/drivers/iio/light/pa12203001.c
+++ b/drivers/iio/light/pa12203001.c
@@ -397,13 +397,19 @@ out_err:
 static int pa12203001_remove(struct i2c_client *client)
 {
        struct iio_dev *indio_dev = i2c_get_clientdata(client);
+       int ret;
 
        iio_device_unregister(indio_dev);
 
        pm_runtime_disable(&client->dev);
        pm_runtime_set_suspended(&client->dev);
 
-       return pa12203001_power_chip(indio_dev, PA12203001_CHIP_DISABLE);
+       ret = pa12203001_power_chip(indio_dev, PA12203001_CHIP_DISABLE);
+       if (ret)
+               dev_warn(&client->dev, "Failed to power down (%pe)\n",
+                        ERR_PTR(ret));
+
+       return 0;
 }
 
 #if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM)