Return early from DistinctErrorLogger's Printf

diff --git a/helpers/general.go b/helpers/general.go
index cf87c04b1f0ac31c5f104be82c9aed417af0f6ba..48e7dbd01a80c63ae8900167af54516dc574def9 100644 (file)
--- a/helpers/general.go
+++ b/helpers/general.go
@@ -162,11 +162,12 @@ type DistinctErrorLogger struct {
 func (l *DistinctErrorLogger) Printf(format string, v ...interface{}) {
        logStatement := fmt.Sprintf(format, v...)
        l.RLock()
-       logged := l.m[logStatement]
-       l.RUnlock()
-       if logged {
+       if l.m[logStatement] {
+               l.RUnlock()
                return
        }
+       l.RUnlock()
+
        l.Lock()
        if !l.m[logStatement] {
                jww.ERROR.Print(logStatement)