i386/kvm: Do not sync nested state during runtime
authorJan Kiszka <jan.kiszka@siemens.com>
Mon, 22 Jul 2019 04:00:08 +0000 (06:00 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 24 Jul 2019 09:21:59 +0000 (11:21 +0200)
Writing the nested state e.g. after a vmport access can invalidate
important parts of the kernel-internal state, and it is not needed as
well. So leave this out from KVM_PUT_RUNTIME_STATE.

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Message-Id: <bdd53f40-4e60-f3ae-7ec6-162198214953@siemens.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
target/i386/kvm.c

index ada89d27cc2c2e50eb7edbb5c71a4b3b9c7b8823..dbbb13772af8f8bbfca1947fbb0270e15bfcea0a 100644 (file)
@@ -3563,12 +3563,12 @@ int kvm_arch_put_registers(CPUState *cpu, int level)
 
     assert(cpu_is_stopped(cpu) || qemu_cpu_is_self(cpu));
 
-    ret = kvm_put_nested_state(x86_cpu);
-    if (ret < 0) {
-        return ret;
-    }
-
     if (level >= KVM_PUT_RESET_STATE) {
+        ret = kvm_put_nested_state(x86_cpu);
+        if (ret < 0) {
+            return ret;
+        }
+
         ret = kvm_put_msr_feature_control(x86_cpu);
         if (ret < 0) {
             return ret;