xhci: make isoc_bei_interval variable interrupter specific.

isoc_bei_interval is used to balance how often completed isochronous
events cause interrupts. If interval is too large then the event ring
may fill up before the completed isoc TRBs are handled.

isoc_bei_interval is tuned based on how full the event ring is.

isoc_bei_interval variable needs to be per interrupter as
with several interrupters each one has its own event ring.

move isoc_bei_interval variable to the interrupter structure.

if a secondary interrupter does not care about this feature then
keep isoc_bei_interval 0.

Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Link: https://lore.kernel.org/r/20240217001017.29969-4-quic_wcheng@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index a7716202a8dd58d74f3d31fd48d0833de89db2be..450adaca68eeb1d73d90c7662615b3cb757f4290 100644 (file)
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -2533,7 +2533,7 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
        if (xhci_add_interrupter(xhci, ir, 0))
                goto fail;
 
-       xhci->isoc_bei_interval = AVOID_BEI_INTERVAL_MAX;
+       ir->isoc_bei_interval = AVOID_BEI_INTERVAL_MAX;
 
        /*
         * XXX: Might need to set the Interrupter Moderation Register to

diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 3d9ec78bfb9f7c4a350b7313d57ee075b84721b4..49f10dc2551639926c89852b2fd6ce5d5a3fcaad 100644 (file)
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -3153,8 +3153,8 @@ irqreturn_t xhci_irq(struct usb_hcd *hcd)
                event_ring_deq = ir->event_ring->dequeue;
 
                /* ring is half-full, force isoc trbs to interrupt more often */
-               if (xhci->isoc_bei_interval > AVOID_BEI_INTERVAL_MIN)
-                       xhci->isoc_bei_interval = xhci->isoc_bei_interval / 2;
+               if (ir->isoc_bei_interval > AVOID_BEI_INTERVAL_MIN)
+                       ir->isoc_bei_interval = ir->isoc_bei_interval / 2;
 
                event_loop = 0;
        }
@@ -4022,7 +4022,8 @@ static int xhci_get_isoc_frame_id(struct xhci_hcd *xhci,
 }
 
 /* Check if we should generate event interrupt for a TD in an isoc URB */
-static bool trb_block_event_intr(struct xhci_hcd *xhci, int num_tds, int i)
+static bool trb_block_event_intr(struct xhci_hcd *xhci, int num_tds, int i,
+                                struct xhci_interrupter *ir)
 {
        if (xhci->hci_version < 0x100)
                return false;
@@ -4033,8 +4034,8 @@ static bool trb_block_event_intr(struct xhci_hcd *xhci, int num_tds, int i)
         * If AVOID_BEI is set the host handles full event rings poorly,
         * generate an event at least every 8th TD to clear the event ring
         */
-       if (i && xhci->quirks & XHCI_AVOID_BEI)
-               return !!(i % xhci->isoc_bei_interval);
+       if (i && ir->isoc_bei_interval && xhci->quirks & XHCI_AVOID_BEI)
+               return !!(i % ir->isoc_bei_interval);
 
        return true;
 }
@@ -4043,6 +4044,7 @@ static bool trb_block_event_intr(struct xhci_hcd *xhci, int num_tds, int i)
 static int xhci_queue_isoc_tx(struct xhci_hcd *xhci, gfp_t mem_flags,
                struct urb *urb, int slot_id, unsigned int ep_index)
 {
+       struct xhci_interrupter *ir;
        struct xhci_ring *ep_ring;
        struct urb_priv *urb_priv;
        struct xhci_td *td;
@@ -4060,6 +4062,7 @@ static int xhci_queue_isoc_tx(struct xhci_hcd *xhci, gfp_t mem_flags,
 
        xep = &xhci->devs[slot_id]->eps[ep_index];
        ep_ring = xhci->devs[slot_id]->eps[ep_index].ring;
+       ir = xhci->interrupters[0];
 
        num_tds = urb->number_of_packets;
        if (num_tds < 1) {
@@ -4147,7 +4150,7 @@ static int xhci_queue_isoc_tx(struct xhci_hcd *xhci, gfp_t mem_flags,
                                td->last_trb = ep_ring->enqueue;
                                td->last_trb_seg = ep_ring->enq_seg;
                                field |= TRB_IOC;
-                               if (trb_block_event_intr(xhci, num_tds, i))
+                               if (trb_block_event_intr(xhci, num_tds, i, ir))
                                        field |= TRB_BEI;
                        }
                        /* Calculate TRB length */

diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index 36c3ba64da515737c5c63377915deb268e975fb5..6e09b9130fae07358b72defd3f57a4e4de45018b 100644 (file)
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1433,6 +1433,7 @@ struct xhci_interrupter {
        struct xhci_intr_reg __iomem *ir_set;
        unsigned int            intr_num;
        bool                    ip_autoclear;
+       u32                     isoc_bei_interval;
        /* For interrupter registers save and restore over suspend/resume */
        u32     s3_irq_pending;
        u32     s3_irq_control;
@@ -1505,7 +1506,6 @@ struct xhci_hcd {
        u8              isoc_threshold;
        /* imod_interval in ns (I * 250ns) */
        u32             imod_interval;
-       u32             isoc_bei_interval;
        int             event_ring_max;
        /* 4KB min, 128MB max */
        int             page_size;