projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2719a9e
)
wifi: wilc1000: remove setting msg.spi
author
David Lechner
<dlechner@baylibre.com>
Thu, 1 Feb 2024 20:12:47 +0000
(14:12 -0600)
committer
Kalle Valo
<kvalo@kernel.org>
Mon, 5 Feb 2024 18:17:48 +0000
(20:17 +0200)
Calling spi_sync() unconditionally sets the spi field of struct
spi_message. Therefore setting msg.spi = spi before calling spi_sync()
has no effect and can be removed.
(spi_message_add_tail() does not access this field.)
Signed-off-by: David Lechner <dlechner@baylibre.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link:
https://msgid.link/20240201201248.2334798-2-dlechner@baylibre.com
drivers/net/wireless/microchip/wilc1000/spi.c
patch
|
blob
|
history
diff --git
a/drivers/net/wireless/microchip/wilc1000/spi.c
b/drivers/net/wireless/microchip/wilc1000/spi.c
index 77b4cdff73c370bf1bbd1e1ebec77eb0cac318b7..7eb0f8a421a3901fcb5780487b06b1de1e3559fe 100644
(file)
--- a/
drivers/net/wireless/microchip/wilc1000/spi.c
+++ b/
drivers/net/wireless/microchip/wilc1000/spi.c
@@
-300,7
+300,6
@@
static int wilc_spi_tx(struct wilc *wilc, u8 *b, u32 len)
memset(&msg, 0, sizeof(msg));
spi_message_init(&msg);
- msg.spi = spi;
spi_message_add_tail(&tr, &msg);
ret = spi_sync(spi, &msg);
@@
-343,7
+342,6
@@
static int wilc_spi_rx(struct wilc *wilc, u8 *rb, u32 rlen)
memset(&msg, 0, sizeof(msg));
spi_message_init(&msg);
- msg.spi = spi;
spi_message_add_tail(&tr, &msg);
ret = spi_sync(spi, &msg);
@@
-381,8
+379,6
@@
static int wilc_spi_tx_rx(struct wilc *wilc, u8 *wb, u8 *rb, u32 rlen)
memset(&msg, 0, sizeof(msg));
spi_message_init(&msg);
- msg.spi = spi;
-
spi_message_add_tail(&tr, &msg);
ret = spi_sync(spi, &msg);
if (ret < 0)