staging: r8188eu: don't accept SIGTERM for cmd thread

At the moment, our command thread can be killed by user space.

[root@host ]# kill `pidof RTW_CMD_THREAD`

The driver will then stop working until the module is unloaded
and reloaded.

Don't process SIGTERM in the command thread. Other drivers that have a
command thread don't process SIGTERM either.

Acked-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20211016181343.3686-4-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
index e17332677daa4b6114866f0eaf0141196a00ef92..b834fac41627b24f28576cc671825942fd46ff79 100644 (file)
--- a/drivers/staging/r8188eu/core/rtw_cmd.c
+++ b/drivers/staging/r8188eu/core/rtw_cmd.c
@@ -243,8 +243,6 @@ int rtw_cmd_thread(void *context)
        struct adapter *padapter = (struct adapter *)context;
        struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
 
-       thread_enter("RTW_CMD_THREAD");
-
        pcmdbuf = pcmdpriv->cmd_buf;
 
        pcmdpriv->cmdthd_running = true;

diff --git a/drivers/staging/r8188eu/include/osdep_service.h b/drivers/staging/r8188eu/include/osdep_service.h
index ee8a64bb31269b60e0e72432ffa2e14185929f57..886a1b6f30b4bcd6c9aa288424996b373b174c8d 100644 (file)
--- a/drivers/staging/r8188eu/include/osdep_service.h
+++ b/drivers/staging/r8188eu/include/osdep_service.h
@@ -160,11 +160,6 @@ static inline unsigned char _cancel_timer_ex(struct timer_list *ptimer)
        return del_timer_sync(ptimer);
 }
 
-static __inline void thread_enter(char *name)
-{
-       allow_signal(SIGTERM);
-}
-
 static inline void flush_signals_thread(void)
 {
        if (signal_pending (current))