watchdog: pcwd_usb: remove unneeded DRIVER_LICENSE #define
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Nov 2017 14:22:03 +0000 (15:22 +0100)
committerWim Van Sebroeck <wim@iguana.be>
Thu, 28 Dec 2017 19:45:50 +0000 (20:45 +0100)
There is no need to #define the license of the driver, just put it in
the MODULE_LICENSE() line directly as a text string.

This allows tools that check that the module license matches the source
code license to work properly, as there is no need to unwind the
unneeded dereference, especially when it is defined just a few lines
above from where it is used.

Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Guenter Roeck <linux@roeck-us.net>
Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/pcwd_usb.c

index 47fe4c5449c993337bb2cfab183d3cc2eac3307d..4d02f26156f9ce10f03993d8dd88b79b4715f848 100644 (file)
 #define DRIVER_VERSION "1.02"
 #define DRIVER_AUTHOR "Wim Van Sebroeck <wim@iguana.be>"
 #define DRIVER_DESC "Berkshire USB-PC Watchdog driver"
-#define DRIVER_LICENSE "GPL"
 #define DRIVER_NAME "pcwd_usb"
 
 MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_LICENSE(DRIVER_LICENSE);
+MODULE_LICENSE("GPL");
 
 #define WATCHDOG_HEARTBEAT 0   /* default heartbeat =
                                                delay-time from dip-switches */