Input: ims-pcu - fix printf string overflow
authorArnd Bergmann <arnd@arndb.de>
Thu, 28 Mar 2024 20:28:56 +0000 (13:28 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 28 Mar 2024 20:29:44 +0000 (13:29 -0700)
clang warns about a string overflow in this driver

drivers/input/misc/ims-pcu.c:1802:2: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 12 [-Werror,-Wformat-truncation]
drivers/input/misc/ims-pcu.c:1814:2: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 12 [-Werror,-Wformat-truncation]

Make the buffer a little longer to ensure it always fits.

Fixes: 628329d52474 ("Input: add IMS Passenger Control Unit driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240326223825.4084412-7-arnd@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/ims-pcu.c

index 6e8cc28debd979eb9b0b276811c615d9a59be850..80d16c92a08b3b0264935b70bf48f7c3d2e8ba02 100644 (file)
@@ -42,8 +42,8 @@ struct ims_pcu_backlight {
 #define IMS_PCU_PART_NUMBER_LEN                15
 #define IMS_PCU_SERIAL_NUMBER_LEN      8
 #define IMS_PCU_DOM_LEN                        8
-#define IMS_PCU_FW_VERSION_LEN         (9 + 1)
-#define IMS_PCU_BL_VERSION_LEN         (9 + 1)
+#define IMS_PCU_FW_VERSION_LEN         16
+#define IMS_PCU_BL_VERSION_LEN         16
 #define IMS_PCU_BL_RESET_REASON_LEN    (2 + 1)
 
 #define IMS_PCU_PCU_B_DEVICE_ID                5