selftests/bpf: Fix test_verifier after introducing resolve_pseudo_ldimm64

Commit 4976b718c355 ("bpf: Introduce pseudo_btf_id") switched
the order of check_subprogs() and resolve_pseudo_ldimm() in
the verifier. Now an empty prog expects to see the error "last
insn is not an the prog of a single invalid ldimm exit or jmp"
instead, because the check for subprogs comes first. It's now
pointless to validate that half of ldimm64 won't be the last
instruction.

Tested:
 # ./test_verifier
 Summary: 1129 PASSED, 537 SKIPPED, 0 FAILED
 and the full set of bpf selftests.

Fixes: 4976b718c355 ("bpf: Introduce pseudo_btf_id")
Signed-off-by: Hao Luo <haoluo@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20201007022857.2791884-1-haoluo@google.com

diff --git a/tools/testing/selftests/bpf/verifier/basic.c b/tools/testing/selftests/bpf/verifier/basic.c
index b8d18642653a0fae58050eaceb250f12fa2c7aa2..de84f0d570821d70ef79d3911ace3e26d8b33817 100644 (file)
--- a/tools/testing/selftests/bpf/verifier/basic.c
+++ b/tools/testing/selftests/bpf/verifier/basic.c
@@ -2,7 +2,7 @@
        "empty prog",
        .insns = {
        },
-       .errstr = "unknown opcode 00",
+       .errstr = "last insn is not an exit or jmp",
        .result = REJECT,
 },
 {

diff --git a/tools/testing/selftests/bpf/verifier/ld_imm64.c b/tools/testing/selftests/bpf/verifier/ld_imm64.c
index 3856dba733e93f23922962bdd00bf05e0d720366..f9297900cea6d44ecd64cf00f3f60099bb17a70a 100644 (file)
--- a/tools/testing/selftests/bpf/verifier/ld_imm64.c
+++ b/tools/testing/selftests/bpf/verifier/ld_imm64.c
@@ -50,14 +50,6 @@
        .errstr = "invalid bpf_ld_imm64 insn",
        .result = REJECT,
 },
-{
-       "test5 ld_imm64",
-       .insns = {
-       BPF_RAW_INSN(BPF_LD | BPF_IMM | BPF_DW, 0, 0, 0, 0),
-       },
-       .errstr = "invalid bpf_ld_imm64 insn",
-       .result = REJECT,
-},
 {
        "test6 ld_imm64",
        .insns = {