drm/i915: Remove bogus LPT iCLKIP WARN
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 16 Jun 2022 09:55:30 +0000 (12:55 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 16 Jun 2022 14:10:23 +0000 (17:10 +0300)
The WARN shouldn't have been added yet. For the moment the
clock that gets passed here is just what the user has requested
(via the modeline) and may not be exactly what iCLKIP can
generate.

Later on the plan is to change things so that we already get
passed the exact clock here, at which point the WARN should
be reintroduced.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6246
Fixes: 97708335b04d ("drm/i915: Introduce struct iclkip_params")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220616095530.15024-1-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_pch_refclk.c

index 752dab11667f4cafd7b72f2ecdc7e886e0599a8e..9934c8a9e240f2b0ac13f46a72c78f6d92ce8594 100644 (file)
@@ -179,7 +179,6 @@ void lpt_program_iclkip(const struct intel_crtc_state *crtc_state)
        lpt_disable_iclkip(dev_priv);
 
        lpt_compute_iclkip(&p, clock);
-       drm_WARN_ON(&dev_priv->drm, lpt_iclkip_freq(&p) != clock);
 
        /* This should not happen with any sane values */
        drm_WARN_ON(&dev_priv->drm, SBI_SSCDIVINTPHASE_DIVSEL(p.divsel) &