dyndbg: show both old and new in change-info

print "old => new" flag values to the info("change") message.

no functional change.

Acked-by: Jason Baron <jbaron@akamai.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Link: https://lore.kernel.org/r/20220904214134.408619-4-jim.cromie@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index a56c1286ffa45a8753d93841cb1f3ede17178c6f..8faf584f2f4b0f426743ff55d51e9bff43eabe2a 100644 (file)
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -156,7 +156,7 @@ static int ddebug_change(const struct ddebug_query *query,
        struct ddebug_table *dt;
        unsigned int newflags;
        unsigned int nfound = 0;
-       struct flagsbuf fbuf;
+       struct flagsbuf fbuf, nbuf;
 
        /* search for matching ddebugs */
        mutex_lock(&ddebug_lock);
@@ -217,11 +217,12 @@ static int ddebug_change(const struct ddebug_query *query,
                                static_branch_enable(&dp->key.dd_key_true);
                        }
 #endif
+                       v4pr_info("changed %s:%d [%s]%s %s => %s\n",
+                                 trim_prefix(dp->filename), dp->lineno,
+                                 dt->mod_name, dp->function,
+                                 ddebug_describe_flags(dp->flags, &fbuf),
+                                 ddebug_describe_flags(newflags, &nbuf));
                        dp->flags = newflags;
-                       v4pr_info("changed %s:%d [%s]%s =%s\n",
-                                trim_prefix(dp->filename), dp->lineno,
-                                dt->mod_name, dp->function,
-                                ddebug_describe_flags(dp->flags, &fbuf));
                }
        }
        mutex_unlock(&ddebug_lock);