iio: afe: iio-rescale: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Sat, 29 Aug 2020 06:47:17 +0000 (08:47 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 3 Sep 2020 18:40:50 +0000 (19:40 +0100)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Peter Rosin <peda@axentia.se>
Link: https://lore.kernel.org/r/20200829064726.26268-9-krzk@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/afe/iio-rescale.c

index 69c0f277ada0cac6e9e999a0f93cf1e0f823c660..e42ea2b1707db9eb4628387a1db3a2b6fbbdebc7 100644 (file)
@@ -276,11 +276,9 @@ static int rescale_probe(struct platform_device *pdev)
        int ret;
 
        source = devm_iio_channel_get(dev, NULL);
-       if (IS_ERR(source)) {
-               if (PTR_ERR(source) != -EPROBE_DEFER)
-                       dev_err(dev, "failed to get source channel\n");
-               return PTR_ERR(source);
-       }
+       if (IS_ERR(source))
+               return dev_err_probe(dev, PTR_ERR(source),
+                                    "failed to get source channel\n");
 
        sizeof_ext_info = iio_get_channel_ext_info_count(source);
        if (sizeof_ext_info) {