projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a04564c
)
cfg80211: check wiphy driver existence for drvinfo report
author
Sergey Matyukevich
<sergey.matyukevich.os@quantenna.com>
Mon, 3 Feb 2020 10:56:50 +0000
(10:56 +0000)
committer
Johannes Berg
<johannes.berg@intel.com>
Fri, 7 Feb 2020 11:53:26 +0000
(12:53 +0100)
When preparing ethtool drvinfo, check if wiphy driver is defined
before dereferencing it. Driver may not exist, e.g. if wiphy is
attached to a virtual platform device.
Signed-off-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Link:
https://lore.kernel.org/r/20200203105644.28875-1-sergey.matyukevich.os@quantenna.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/ethtool.c
patch
|
blob
|
history
diff --git
a/net/wireless/ethtool.c
b/net/wireless/ethtool.c
index a9c0f368db5d27ed72159a2395a4a4ec60234ed0..24e18405cdb48fff6090831f656b4f883c926109 100644
(file)
--- a/
net/wireless/ethtool.c
+++ b/
net/wireless/ethtool.c
@@
-7,9
+7,13
@@
void cfg80211_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
{
struct wireless_dev *wdev = dev->ieee80211_ptr;
+ struct device *pdev = wiphy_dev(wdev->wiphy);
- strlcpy(info->driver, wiphy_dev(wdev->wiphy)->driver->name,
- sizeof(info->driver));
+ if (pdev->driver)
+ strlcpy(info->driver, pdev->driver->name,
+ sizeof(info->driver));
+ else
+ strlcpy(info->driver, "N/A", sizeof(info->driver));
strlcpy(info->version, init_utsname()->release, sizeof(info->version));