vga: fix display update region calculation
authorGerd Hoffmann <kraxel@redhat.com>
Tue, 9 May 2017 10:48:39 +0000 (12:48 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Thu, 11 May 2017 07:50:32 +0000 (09:50 +0200)
vga display update mis-calculated the region for the dirty bitmap
snapshot in case the scanlines are padded.  This can triggere an
assert in cpu_physical_memory_snapshot_get_dirty().

Fixes: fec5e8c92becad223df9d972770522f64aafdb72
Reported-by: Kevin Wolf <kwolf@redhat.com>
Reported-by: 李强 <liqiang6-s@360.cn>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20170509104839.19415-1-kraxel@redhat.com

hw/display/vga.c

index b2516c8d2165e2d6cfeab33c7b30068ecfb1793b..dcc95f88e2261b3903dfb3de1915aeb812bc0cad 100644 (file)
@@ -1630,7 +1630,7 @@ static void vga_draw_graphic(VGACommonState *s, int full_update)
     if (!full_update) {
         vga_sync_dirty_bitmap(s);
         snap = memory_region_snapshot_and_clear_dirty(&s->vram, addr1,
-                                                      bwidth * height,
+                                                      line_offset * height,
                                                       DIRTY_MEMORY_VGA);
     }