projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0c15469
)
dmaengine: fsl-edma: fix wrong pointer check in fsl_edma3_attach_pd()
author
Yang Yingliang
<yangyingliang@huawei.com>
Wed, 29 Nov 2023 09:00:00 +0000
(17:00 +0800)
committer
Vinod Koul
<vkoul@kernel.org>
Mon, 11 Dec 2023 12:06:54 +0000
(17:36 +0530)
device_link_add() returns NULL pointer not PTR_ERR() when it fails,
so replace the IS_ERR() check with NULL pointer check.
Fixes: 72f5801a4e2b ("dmaengine: fsl-edma: integrate v3 support")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link:
https://lore.kernel.org/r/20231129090000.841440-1-yangyingliang@huaweicloud.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/fsl-edma-main.c
patch
|
blob
|
history
diff --git
a/drivers/dma/fsl-edma-main.c
b/drivers/dma/fsl-edma-main.c
index aea7a703dda7e7c42623bc0ca23e77408308246b..238a69bd0d6f5d3ba6d8329543c49d3a750dba21 100644
(file)
--- a/
drivers/dma/fsl-edma-main.c
+++ b/
drivers/dma/fsl-edma-main.c
@@
-396,9
+396,8
@@
static int fsl_edma3_attach_pd(struct platform_device *pdev, struct fsl_edma_eng
link = device_link_add(dev, pd_chan, DL_FLAG_STATELESS |
DL_FLAG_PM_RUNTIME |
DL_FLAG_RPM_ACTIVE);
- if (IS_ERR(link)) {
- dev_err(dev, "Failed to add device_link to %d: %ld\n", i,
- PTR_ERR(link));
+ if (!link) {
+ dev_err(dev, "Failed to add device_link to %d\n", i);
return -EINVAL;
}