projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2dee54b
)
ALSA: jack: Check the return value of kstrdup()
author
Xiaoke Wang
<xkernel.wang@foxmail.com>
Mon, 13 Dec 2021 07:39:31 +0000
(15:39 +0800)
committer
Takashi Iwai
<tiwai@suse.de>
Mon, 13 Dec 2021 09:38:27 +0000
(10:38 +0100)
kstrdup() can return NULL, it is better to check the return value of it.
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Cc: <stable@vger.kernel.org>
Link:
https://lore.kernel.org/r/tencent_094816F3522E0DC704056C789352EBBF0606@qq.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/jack.c
patch
|
blob
|
history
diff --git
a/sound/core/jack.c
b/sound/core/jack.c
index 32350c6aba849d41af1586a0583f6b1f87b51d35..537df1e98f8acf6c6cf7dd04651046e02332187f 100644
(file)
--- a/
sound/core/jack.c
+++ b/
sound/core/jack.c
@@
-509,6
+509,10
@@
int snd_jack_new(struct snd_card *card, const char *id, int type,
return -ENOMEM;
jack->id = kstrdup(id, GFP_KERNEL);
+ if (jack->id == NULL) {
+ kfree(jack);
+ return -ENOMEM;
+ }
/* don't creat input device for phantom jack */
if (!phantom_jack) {