media: stb0899: Simplify check
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 29 Apr 2024 15:04:41 +0000 (16:04 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 3 May 2024 10:03:01 +0000 (11:03 +0100)
chip_id is an unsigned number, it can never be < 0

Fixes cocci check:
drivers/media/dvb-frontends/stb0899_drv.c:1280:8-15: WARNING: Unsigned expression compared with zero: chip_id > 0

Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-2-3c4865f5a4b0@chromium.org
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/dvb-frontends/stb0899_drv.c

index 2f4d8fb400cd661cea94c3cecf61f9c2f2d3f123..35634f9a8ab523db92d8e9624d67217a382c7fe6 100644 (file)
@@ -1277,7 +1277,7 @@ static int stb0899_get_dev_id(struct stb0899_state *state)
        dprintk(state->verbose, FE_ERROR, 1, "Demodulator Core ID=[%s], Version=[%d]", (char *) &demod_str, demod_ver);
        CONVERT32(STB0899_READ_S2REG(STB0899_S2FEC, FEC_CORE_ID_REG), (char *)&fec_str);
        fec_ver = STB0899_READ_S2REG(STB0899_S2FEC, FEC_VER_ID_REG);
-       if (! (chip_id > 0)) {
+       if (!chip_id) {
                dprintk(state->verbose, FE_ERROR, 1, "couldn't find a STB 0899");
 
                return -ENODEV;