HID: amd_sfh: Remove duplicate cleanup for SFH1.1
authorBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Tue, 9 May 2023 06:58:56 +0000 (12:28 +0530)
committerJiri Kosina <jkosina@suse.cz>
Tue, 23 May 2023 13:58:30 +0000 (15:58 +0200)
A duplicate cleanup is performed that is not necessary. As a result,
remove duplicate cleanup and use common cleanup.

Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c

index bb8bd7892b674634016e407ac612bd15c9df9eef..2102d53bd51f750637f682004993ec538178fc9e 100644 (file)
@@ -174,20 +174,8 @@ static int amd_sfh1_1_hid_client_init(struct amd_mp2_dev *privdata)
                        cl_data->is_any_sensor_enabled = true;
                        cl_data->sensor_sts[i] = SENSOR_ENABLED;
                        rc = amdtp_hid_probe(i, cl_data);
-                       if (rc) {
-                               mp2_ops->stop(privdata, cl_data->sensor_idx[i]);
-                               status = amd_sfh_wait_for_response
-                                       (privdata, cl_data->sensor_idx[i], DISABLE_SENSOR);
-                               if (status == 0)
-                                       status = SENSOR_DISABLED;
-                               if (status != SENSOR_ENABLED)
-                                       cl_data->sensor_sts[i] = SENSOR_DISABLED;
-                               dev_dbg(dev, "sid 0x%x (%s) status 0x%x\n",
-                                       cl_data->sensor_idx[i],
-                                       get_sensor_name(cl_data->sensor_idx[i]),
-                                       cl_data->sensor_sts[i]);
+                       if (rc)
                                goto cleanup;
-                       }
                } else {
                        cl_data->sensor_sts[i] = SENSOR_DISABLED;
                }