netfilter: xt_IDLETIMER: replace snprintf in show functions with sysfs_emit
authorJing Yao <yao.jing2@zte.com.cn>
Thu, 4 Nov 2021 11:49:11 +0000 (11:49 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 8 Nov 2021 11:14:05 +0000 (12:14 +0100)
coccicheck complains about the use of snprintf() in sysfs show
functions:
WARNING use scnprintf or sprintf

Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more
sense.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jing Yao <yao.jing2@zte.com.cn>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/xt_IDLETIMER.c

index 2f7cf5ecebf4f3b66f817e6e3d17e5114924189f..0f8bb0bf558f97a304860133bf781003005fa028 100644 (file)
@@ -85,9 +85,9 @@ static ssize_t idletimer_tg_show(struct device *dev,
        mutex_unlock(&list_mutex);
 
        if (time_after(expires, jiffies) || ktimespec.tv_sec > 0)
-               return snprintf(buf, PAGE_SIZE, "%ld\n", time_diff);
+               return sysfs_emit(buf, "%ld\n", time_diff);
 
-       return snprintf(buf, PAGE_SIZE, "0\n");
+       return sysfs_emit(buf, "0\n");
 }
 
 static void idletimer_tg_work(struct work_struct *work)