iio: adc: fix the return value handle for platform_get_irq()

There is no possible for platform_get_irq() to return 0
and the return value of platform_get_irq() is more sensible
to show the error reason.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20230727131607.2897937-1-ruanjinjie@huawei.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c
index 44e1e53ada729490bf6277c9252e93189e821c16..0d6885413a7ee255960bff597b8311112a5ca2d5 100644 (file)
--- a/drivers/iio/adc/bcm_iproc_adc.c
+++ b/drivers/iio/adc/bcm_iproc_adc.c
@@ -540,8 +540,8 @@ static int iproc_adc_probe(struct platform_device *pdev)
        }
 
        adc_priv->irqno = platform_get_irq(pdev, 0);
-       if (adc_priv->irqno <= 0)
-               return -ENODEV;
+       if (adc_priv->irqno < 0)
+               return adc_priv->irqno;
 
        ret = regmap_update_bits(adc_priv->regmap, IPROC_REGCTL2,
                                IPROC_ADC_AUXIN_SCAN_ENA, 0);

diff --git a/drivers/iio/adc/lpc32xx_adc.c b/drivers/iio/adc/lpc32xx_adc.c
index 732c924a976dd91f9ef902230a4c0af63bdd07ca..e34ed7dacd89349c9b189136a0971fc0a48b7186 100644 (file)
--- a/drivers/iio/adc/lpc32xx_adc.c
+++ b/drivers/iio/adc/lpc32xx_adc.c
@@ -176,8 +176,8 @@ static int lpc32xx_adc_probe(struct platform_device *pdev)
        }
 
        irq = platform_get_irq(pdev, 0);
-       if (irq <= 0)
-               return -ENXIO;
+       if (irq < 0)
+               return irq;
 
        retval = devm_request_irq(&pdev->dev, irq, lpc32xx_adc_isr, 0,
                                  LPC32XXAD_NAME, st);

diff --git a/drivers/iio/adc/npcm_adc.c b/drivers/iio/adc/npcm_adc.c
index ba4cd8f49f66ca256743981372e1002d90df0efe..3d9207c160eb997b8f115512e244de4b3d77d302 100644 (file)
--- a/drivers/iio/adc/npcm_adc.c
+++ b/drivers/iio/adc/npcm_adc.c
@@ -244,8 +244,8 @@ static int npcm_adc_probe(struct platform_device *pdev)
        info->adc_sample_hz = clk_get_rate(info->adc_clk) / ((div + 1) * 2);
 
        irq = platform_get_irq(pdev, 0);
-       if (irq <= 0) {
-               ret = -EINVAL;
+       if (irq < 0) {
+               ret = irq;
                goto err_disable_clk;
        }
 

diff --git a/drivers/iio/adc/spear_adc.c b/drivers/iio/adc/spear_adc.c
index d93e580b3dc5b479cb0761c64c6a97a3891f0a63..ad54ef798109058c6178f5194e8b2329daa168c8 100644 (file)
--- a/drivers/iio/adc/spear_adc.c
+++ b/drivers/iio/adc/spear_adc.c
@@ -310,8 +310,8 @@ static int spear_adc_probe(struct platform_device *pdev)
        }
 
        irq = platform_get_irq(pdev, 0);
-       if (irq <= 0) {
-               ret = -EINVAL;
+       if (irq < 0) {
+               ret = irq;
                goto errout2;
        }