pwm: jz4740: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 26 Aug 2020 14:47:43 +0000 (16:47 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 24 Sep 2020 07:18:10 +0000 (09:18 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-jz4740.c

index 5830ac2bdf6acf6ba7a5d1c160fec00a9f9f4edb..00c642fa2eed15266e56f375b1fc2008aac1d986 100644 (file)
@@ -60,12 +60,9 @@ static int jz4740_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
        snprintf(name, sizeof(name), "timer%u", pwm->hwpwm);
 
        clk = clk_get(chip->dev, name);
-       if (IS_ERR(clk)) {
-               if (PTR_ERR(clk) != -EPROBE_DEFER)
-                       dev_err(chip->dev, "Failed to get clock: %pe", clk);
-
-               return PTR_ERR(clk);
-       }
+       if (IS_ERR(clk))
+               return dev_err_probe(chip->dev, PTR_ERR(clk),
+                                    "Failed to get clock\n");
 
        err = clk_prepare_enable(clk);
        if (err < 0) {