drm/xe/device: clean up on error in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 5 Jan 2024 12:22:23 +0000 (15:22 +0300)
committerMatthew Brost <matthew.brost@intel.com>
Thu, 11 Jan 2024 02:27:39 +0000 (18:27 -0800)
This error path should clean up before returning.

Smatch detected this bug:
  drivers/gpu/drm/xe/xe_device.c:487 xe_device_probe() warn: missing unwind goto?

Fixes: 4cb12b71923b ("drm/xe/xe2: Determine bios enablement for flat ccs on igfx")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
drivers/gpu/drm/xe/xe_device.c

index 004e65544e8d823d319570dc1cbd03974cbf68c7..a94c0b27f04e8f724601636ff6e080a4d6a68e69 100644 (file)
@@ -495,7 +495,7 @@ int xe_device_probe(struct xe_device *xe)
 
        err = xe_device_set_has_flat_ccs(xe);
        if (err)
-               return err;
+               goto err_irq_shutdown;
 
        err = xe_mmio_probe_vram(xe);
        if (err)