ARM: 9328/1: mm: try VMA lock-based page fault handling first
authorWang Kefeng <wangkefeng.wang@huawei.com>
Thu, 19 Oct 2023 11:21:35 +0000 (12:21 +0100)
committerRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tue, 5 Dec 2023 11:42:13 +0000 (11:42 +0000)
Attempt VMA lock-based page fault handling first, and fall back to the
existing mmap_lock-based handling if that fails, the ebizzy benchmark
shows 25% improvement on qemu with 2 cpus.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
arch/arm/Kconfig
arch/arm/mm/fault.c

index f8567e95f98bef4ac91bf1088552b64f79422de6..8f47d6762ea4b0454dfd78376616c42cbbd67b86 100644 (file)
@@ -35,6 +35,7 @@ config ARM
        select ARCH_OPTIONAL_KERNEL_RWX_DEFAULT if CPU_V7
        select ARCH_SUPPORTS_ATOMIC_RMW
        select ARCH_SUPPORTS_HUGETLBFS if ARM_LPAE
+       select ARCH_SUPPORTS_PER_VMA_LOCK
        select ARCH_USE_BUILTIN_BSWAP
        select ARCH_USE_CMPXCHG_LOCKREF
        select ARCH_USE_MEMTEST
index fef62e4a9edde6ce1343c8a81e4e65b883e11e83..e96fb40b9cc32a64b5a0379e5ee42bd9e38f1aa5 100644 (file)
@@ -278,6 +278,35 @@ do_page_fault(unsigned long addr, unsigned int fsr, struct pt_regs *regs)
 
        perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS, 1, regs, addr);
 
+       if (!(flags & FAULT_FLAG_USER))
+               goto lock_mmap;
+
+       vma = lock_vma_under_rcu(mm, addr);
+       if (!vma)
+               goto lock_mmap;
+
+       if (!(vma->vm_flags & vm_flags)) {
+               vma_end_read(vma);
+               goto lock_mmap;
+       }
+       fault = handle_mm_fault(vma, addr, flags | FAULT_FLAG_VMA_LOCK, regs);
+       if (!(fault & (VM_FAULT_RETRY | VM_FAULT_COMPLETED)))
+               vma_end_read(vma);
+
+       if (!(fault & VM_FAULT_RETRY)) {
+               count_vm_vma_lock_event(VMA_LOCK_SUCCESS);
+               goto done;
+       }
+       count_vm_vma_lock_event(VMA_LOCK_RETRY);
+
+       /* Quick path to respond to signals */
+       if (fault_signal_pending(fault, regs)) {
+               if (!user_mode(regs))
+                       goto no_context;
+               return 0;
+       }
+lock_mmap:
+
 retry:
        vma = lock_mm_and_find_vma(mm, addr, regs);
        if (unlikely(!vma)) {
@@ -316,6 +345,7 @@ retry:
        }
 
        mmap_read_unlock(mm);
+done:
 
        /*
         * Handle the "normal" case first - VM_FAULT_MAJOR