NFSD: Add nfsd4_encode_fattr4_maxread()
authorChuck Lever <chuck.lever@oracle.com>
Mon, 18 Sep 2023 13:59:39 +0000 (09:59 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 16 Oct 2023 16:44:19 +0000 (12:44 -0400)
Refactor the encoder for FATTR4_MAXREAD into a helper. In a
subsequent patch, this helper will be called from a bitmask loop.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c

index 7ded6d20d833c57382cf33d89ba73fe9b95cd386..0280b12f603d6a3cf3fec851a9a448e9f8128a5d 100644 (file)
@@ -3171,6 +3171,12 @@ static __be32 nfsd4_encode_fattr4_maxname(struct xdr_stream *xdr,
        return nfsd4_encode_uint32_t(xdr, args->statfs.f_namelen);
 }
 
+static __be32 nfsd4_encode_fattr4_maxread(struct xdr_stream *xdr,
+                                         const struct nfsd4_fattr_args *args)
+{
+       return nfsd4_encode_uint64_t(xdr, svc_max_payload(args->rqstp));
+}
+
 /*
  * Note: @fhp can be NULL; in this case, we might have to compose the filehandle
  * ourselves.
@@ -3440,10 +3446,9 @@ nfsd4_encode_fattr(struct xdr_stream *xdr, struct svc_fh *fhp,
                        goto out;
        }
        if (bmval0 & FATTR4_WORD0_MAXREAD) {
-               p = xdr_reserve_space(xdr, 8);
-               if (!p)
-                       goto out_resource;
-               p = xdr_encode_hyper(p, (u64) svc_max_payload(rqstp));
+               status = nfsd4_encode_fattr4_maxread(xdr, &args);
+               if (status != nfs_ok)
+                       goto out;
        }
        if (bmval0 & FATTR4_WORD0_MAXWRITE) {
                p = xdr_reserve_space(xdr, 8);