f2fs: fix uninitialized skipped_gc_rwsem
authorYonggil Song <yonggil.song@samsung.com>
Thu, 16 Feb 2023 07:13:50 +0000 (16:13 +0900)
committerJaegeuk Kim <jaegeuk@kernel.org>
Wed, 29 Mar 2023 22:17:38 +0000 (15:17 -0700)
When f2fs skipped a gc round during victim migration, there was a bug which
would skip all upcoming gc rounds unconditionally because skipped_gc_rwsem
was not initialized. It fixes the bug by correctly initializing the
skipped_gc_rwsem inside the gc loop.

Fixes: 6f8d4455060d ("f2fs: avoid fi->i_gc_rwsem[WRITE] lock in f2fs_gc")
Signed-off-by: Yonggil Song <yonggil.song@samsung.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/gc.c

index 0a9dfa4598606709c3ceba02d22fcba6c1328212..292a17d62f569a15c4dbf021f4d4b0e469655f09 100644 (file)
@@ -1791,8 +1791,8 @@ int f2fs_gc(struct f2fs_sb_info *sbi, struct f2fs_gc_control *gc_control)
                                prefree_segments(sbi));
 
        cpc.reason = __get_cp_reason(sbi);
-       sbi->skipped_gc_rwsem = 0;
 gc_more:
+       sbi->skipped_gc_rwsem = 0;
        if (unlikely(!(sbi->sb->s_flags & SB_ACTIVE))) {
                ret = -EINVAL;
                goto stop;